Skip to content

Extract hardcoded AD ports to constant for maintainability #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aahmed-spec merged 2 commits into from
Jan 7, 2026
Merged

Extract hardcoded AD ports to constant for maintainability #752

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a648d9
Initial plan
Copilot Jan 7, 2026
6a0065d
Extract AD ports to constant $AD_WELL_KNOWN_PORTS
Copilot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/powershell/tests/Test-Assessment.25395.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ function Test-Assessment-25395 {
[CmdletBinding()]
param()

# Active Directory well-known ports
$AD_WELL_KNOWN_PORTS = @('53','88','135','389','445','464','636','3268','3269')

#region Helper Functions

function Test-IsBroadCidr {
Expand Down Expand Up @@ -98,11 +101,10 @@ function Test-Assessment-25395 {
System.Boolean - True if port is a valid AD well-known port, false otherwise.
#>
param([string]$Port)
$valid = @('53','88','135','389','445','464','636','3268','3269')
if ($Port -match '^(\d+)-(\d+)$') {
return ($matches[1] -eq $matches[2] -and $valid -contains $matches[1])
return ($matches[1] -eq $matches[2] -and $AD_WELL_KNOWN_PORTS -contains $matches[1])
}
return ($valid -contains $Port)
return ($AD_WELL_KNOWN_PORTS -contains $Port)
}

#endregion Helper Functions
Expand Down