refactor: fix mTBILL rv swapper name#196
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the address configuration by renaming a key associated with a redemption vault swapper. The change aims to enhance the readability and precision of the codebase by using a more descriptive name for the address, ensuring that its function as a swapper is explicitly clear. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request renames the redemptionVault property to redemptionVaultSwapper within the midasAddressesPerNetwork configuration in config/constants/addresses.ts. A critical issue was identified where the address assigned to redemptionVaultSwapper for mTBILL on the base network is incorrect, appearing to be a mBASIS token address from the main network, which will cause runtime failures and needs correction.
| dataFeed: '0xcbCf1e67F1988e2572a2A620321Aef2ff73369f0', | ||
| depositVault: '0x8978e327FE7C72Fa4eaF4649C23147E279ae1470', | ||
| redemptionVault: '0x2a8c22E3b10036f3AEF5875d04f8441d4188b656', | ||
| redemptionVaultSwapper: '0x2a8c22E3b10036f3AEF5875d04f8441d4188b656', |
There was a problem hiding this comment.
The address 0x2a8c22E3b10036f3AEF5875d04f8441d4188b656 for redemptionVaultSwapper appears to be incorrect. This address corresponds to the mBASIS token on the main network (see line 235), not a redemption vault on the base network. This is likely a copy-paste error and will cause issues at runtime. Please replace it with the correct address for the mTBILL redemption vault swapper on the base network.
No description provided.