Skip to content

refactor: fix mTBILL rv swapper name#196

Merged
dmytro-horbatenko merged 2 commits intomainfrom
fix/mtbill-swapper-addresses
Mar 30, 2026
Merged

refactor: fix mTBILL rv swapper name#196
dmytro-horbatenko merged 2 commits intomainfrom
fix/mtbill-swapper-addresses

Conversation

@dmytro-horbatenko
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the address configuration by renaming a key associated with a redemption vault swapper. The change aims to enhance the readability and precision of the codebase by using a more descriptive name for the address, ensuring that its function as a swapper is explicitly clear.

Highlights

  • Address Configuration Refactoring: Renamed the redemptionVault property to redemptionVaultSwapper for mTBILL entries within the midasAddressesPerNetwork configuration. This change improves clarity and accuracy in identifying the purpose of the address.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the redemptionVault property to redemptionVaultSwapper within the midasAddressesPerNetwork configuration in config/constants/addresses.ts. A critical issue was identified where the address assigned to redemptionVaultSwapper for mTBILL on the base network is incorrect, appearing to be a mBASIS token address from the main network, which will cause runtime failures and needs correction.

dataFeed: '0xcbCf1e67F1988e2572a2A620321Aef2ff73369f0',
depositVault: '0x8978e327FE7C72Fa4eaF4649C23147E279ae1470',
redemptionVault: '0x2a8c22E3b10036f3AEF5875d04f8441d4188b656',
redemptionVaultSwapper: '0x2a8c22E3b10036f3AEF5875d04f8441d4188b656',
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The address 0x2a8c22E3b10036f3AEF5875d04f8441d4188b656 for redemptionVaultSwapper appears to be incorrect. This address corresponds to the mBASIS token on the main network (see line 235), not a redemption vault on the base network. This is likely a copy-paste error and will cause issues at runtime. Please replace it with the correct address for the mTBILL redemption vault swapper on the base network.

@dmytro-horbatenko dmytro-horbatenko merged commit 7ce5a2f into main Mar 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants