Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for the Optimism network and implements the mRe7ETH token ecosystem, including its associated custom aggregator feeds, data feeds, and vault contracts. The changes encompass extensive configuration updates for network parameters, contract addresses, and deployment scripts. Feedback identifies critical placeholder 'dummy' addresses in the mRe7ETH deployment configuration that must be updated before production use, as well as a minor formatting issue regarding a missing newline in the roles documentation.
| liquidityProvider: 'dummy', | ||
| enableSanctionsList: true, | ||
| swapperVault: 'dummy', |
There was a problem hiding this comment.
The liquidityProvider and swapperVault properties are set to 'dummy'. These placeholder values must be replaced with the correct addresses before deployment to ensure the redemption vault swapper functions correctly.
| | ***pauser*** | `0x8f4b7dfb05ebffc760b8d398af5b0d327b890a22f9030321740d68be514e8f60` | | ||
| | ***customFeedAdmin*** | `0xc9f03f672dadad915001ad6a5393aba8482f9c28ea275c4b5480f7b994778ed5` | | ||
| | ***depositVaultAdmin*** | `0x798de9824ed446b72c97afa7b28844dbbfbde8830d58977e9462289a757aafb7` | | ||
| | ***redemptionVaultAdmin*** | `0x37c36a61c043b91d5ec6d117c64ef865031d25c49609bb25d6530b1fcb8e2e1c` | No newline at end of file |
There was a problem hiding this comment.
This file is missing a final newline. Please add one to adhere to standard file formatting conventions.
2 participants
No description provided.