Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the .yarnrc.yml configuration by reordering existing settings and introducing a 7-day age gate for npm packages. Feedback highlights that disabling scripts will prevent the automatic setup of Husky git hooks, which may disrupt the development workflow unless manually documented. Additionally, the 10080-minute age gate is flagged as overly restrictive, as it could delay the adoption of critical security patches; a shorter window of 24 to 48 hours is recommended instead.
| defaultSemverRangePrefix: '' | ||
|
|
||
| nodeLinker: node-modules | ||
| enableScripts: false |
There was a problem hiding this comment.
Setting enableScripts: false disables the postinstall script in package.json, which prevents husky from automatically setting up git hooks for developers. This means the precommit hook (which runs codestyle) will not be initialized on fresh installs. If this is a deliberate security choice, consider documenting a manual setup step for contributors (e.g., running yarn husky manually).
| nodeLinker: node-modules | ||
|
|
||
| enableScripts: false | ||
| npmMinimalAgeGate: 10080 |
There was a problem hiding this comment.
An npmMinimalAgeGate of 7 days (10080 minutes) is exceptionally restrictive. While it provides a buffer against malicious new packages, it also prevents the team from installing critical security patches or urgent bug fixes for a full week after their release. A value of 1440 (24 hours) or 2880 (48 hours) is generally recommended to balance security with the ability to respond to vulnerabilities.
npmMinimalAgeGate: 1440
2 participants
No description provided.