fix(cache): use setWithTTL for Redis to properly set TTL #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries - Add optional setWithTTL method to CacheStore interface - Create helper function to use setWithTTL when available - Replace all store.set() calls with TTL-aware helper - Export missing types (CacheBackendConfig, CacheStore, CacheEntry) and createCacheBackend function - Forward TTL option from createCached to createCachedFunction for consistency - Fixes issue where Redis keys were stored without expiration - Fixes issue where TTL needed to be specified twice when using createCached
|
@Yuripetusko is attempting to deploy a commit to the Pontus Abrahamsson's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Problem:
The cache system wasn't actually using TTL for Redis. While
RedisCacheStorehas asetWithTTL()method that uses Redis SETEX, all cache writes were calling regularset()instead. This meant:Also, when using
createCached(), you had to passttltwice - once tocreateCached()and again when calling the returned function. Pretty confusing.Changes:
setWithTTLtoCacheStoreinterfacesetWithTTLwhen available, falls back toset()otherwisettlfromcreateCached()tocreateCachedFunction()so you only specify it onceCacheBackendConfig,CacheStore,CacheEntry, andcreateCacheBackend(these were referenced in README but not exported)