Merge pull request #1043 from chouandy/hotfix/update-http-router-meth…

…od-type-to-inline feat: update http-router Method to inline allowed values
middyjs · Apr 17, 2023 · 6d62e71 · 6d62e71
2 parents d3cfb78 + 57defd2
commit 6d62e71
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/packages/http-router/index.d.ts b/packages/http-router/index.d.ts
@@ -8,16 +8,7 @@ import {
   Handler as LambdaHandler
 } from 'aws-lambda'
 
-export enum Method {
-  Get = 'GET',
-  Post = 'POST',
-  Put = 'PUT',
-  Patch = 'PATCH',
-  Delete = 'DELETE',
-  Options = 'OPTIONS',
-  Head = 'HEAD',
-  Any = 'ANY'
-}
+export type Method = 'GET' | 'POST' | 'PUT' | 'PATCH' | 'DELETE' | 'OPTIONS' | 'HEAD' | 'ANY'
 
 type TResult = ALBResult | APIGatewayProxyResult
 

diff --git a/packages/http-router/index.test-d.ts b/packages/http-router/index.test-d.ts
@@ -1,6 +1,6 @@
 import { expectType } from 'tsd'
 import middy from '@middy/core'
-import httpRouterHandler, { Method } from '.'
+import httpRouterHandler from '.'
 import {
   APIGatewayProxyEvent,
   APIGatewayProxyResult,
@@ -16,7 +16,7 @@ const lambdaHandler: LambdaHandler<APIGatewayProxyEvent, APIGatewayProxyResult>
 
 const middleware = httpRouterHandler([
   {
-    method: Method.Get,
+    method: 'GET',
     path: '/',
     handler: lambdaHandler
   }