Conversation
…ng blockfrost placeholder
hseeberger
approved these changes
Feb 5, 2026
Collaborator
hseeberger
left a comment
hseeberger
left a comment
There was a problem hiding this comment.
One change, please, then merge.
spo-indexer/config.yaml
Outdated
| reconnect_max_delay: "10s" # 10ms, 100ms, 1s, 10s | ||
| reconnect_max_attempts: 30 # Roughly 5m | ||
| blockfrost_id: "${BLOCKFROST_PROJECT_ID}" | ||
| blockfrost_id: "" # provide via APP__INFRA__NODE__BLOCKFROST_ID env var |
Collaborator
There was a problem hiding this comment.
Please remove this line altogether, like we do for other secrets. Also no comment. Consistency.
cosmir17
commented
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
The pub_sub, ledger_state_storage sections in config.yaml and the APP__INFRA__PUB_SUB__URL in the justfile were carried over from ProtoFire's original SPO integration (PR #526). spo-indexer does not use NATS. The ${BLOCKFROST_PROJECT_ID} in config.yaml was also from ProtoFire — it looks like shell variable substitution but figment doesn't expand it; the actual mechanism is the APP__INFRA__NODE__BLOCKFROST_ID env var override.