Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry-pick UPSTREAM: docker/distribution: 3296: allow pointing to an AWS config … #30

Open
wants to merge 2 commits into
base: v3
Choose a base branch
from
Open

cherry-pick UPSTREAM: docker/distribution: 3296: allow pointing to an AWS config … #30

wants to merge 2 commits into from

Commits on Jul 11, 2023

  1. Revert "remove v3 from name for discovery" 

    This reverts commit aa6c4b2.
    @kaovilai
    kaovilai committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0c78da2 View commit details
    Browse the repository at this point in the history

  2. UPSTREAM: docker/distribution: 3296: allow pointing to an AWS config … 

    …file as a parameter for the s3 driver

Recognize a new parameter when setting up the AWS client so that a generic AWS config file can be used instead of having to specify AWS access and secret keys.

This should allow someone to use different authentication methods beyond just access key, secret key (and optionally session token).

Using the current supported auth methods a valid file would look like:
```
[default]
aws_access_key_id = AKMYAWSACCCESSKEYID
aws_secret_access_key = myawssecretaccesskey
```

But you can also specify alternative auth methods:
```
[default]
role_arn = arn:aws:iam:ACCOUNT_NUM:role/ROLE_NAME
web_identity_token_file = /path/to/token
```

Signed-off-by: Tiger Kaovilai <[email protected]>
    @kaovilai
    Joel Diaz authored and kaovilai committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bb6889a View commit details
    Browse the repository at this point in the history