Skip to content

Commit

Permalink
NonAdminBackup updates to align with updated design
Browse files Browse the repository at this point in the history
Additional improvements to the NonAdminBackup:
 - Use generic condition names (Accepted, Queued)
 - Introduce VeleroBackupNamespace
 - Change Status: OadpVeleroBackup to VeleroBackupName
 - Use CammelCase for condition reasoan

Signed-off-by: Michal Pryc <[email protected]>
  • Loading branch information
mpryc committed Apr 29, 2024
1 parent d1a710a commit 3ed92ed
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion config/manager/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ kind: Kustomization
images:
- name: controller
newName: quay.io/konveyor/oadp-non-admin
newTag: latest
newTag: latest
1 change: 1 addition & 0 deletions internal/common/function/function.go
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ func CheckVeleroBackupLabels(backup *velerov1api.Backup) bool {
return exists && value == constant.ManagedByLabelValue
}

// TODO not used
// GetNonAdminBackupFromVeleroBackup return referenced NonAdminBackup object from Velero Backup object, if no error occurs
func GetNonAdminBackupFromVeleroBackup(ctx context.Context, clientInstance client.Client, backup *velerov1api.Backup) (*nacv1alpha1.NonAdminBackup, error) {
// Check if the backup has the required annotations to identify the associated NonAdminBackup object
Expand Down

0 comments on commit 3ed92ed

Please sign in to comment.