Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #89 - Use custom UUID for NAB Object #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for #89 - Use custom UUID for NAB Object #101

wants to merge 1 commit into from
+594 −291

Commits on Oct 14, 2024

  1. Fix for migtools#89 - Use custom UUID for NAB Object 

    With this change a new UUID is generated to reference parent/child relationship
between objects in the Non Admin Controller use cases.

The first consumer of this UUID is a Velero Backup, created when the
NonAdminBackup object is reconciled.

The NonAdminBackup object generates the NAC UUID and stores it in its
Status. This prevents users from modifying it. The UUID is later used
to create the Velero Backup during reconciliation.

While the NAC UUID is currently used as the Velero Backup name, this is
not required, as the UUID is also stored as a Velero Backup label, which
is used during the reconcile loop. Usage of NAC UUID as Velero Backup name
is to easy it's creation.

This PR also includes small changes to fix linting issues of the code,
as well reworks the tests to properly take advantage of gingko BeforeEach
function.

Signed-off-by: Michal Pryc <[email protected]>
    @mpryc
    mpryc committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2cbd085 View commit details
    Browse the repository at this point in the history