Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of cowbuilder update lock #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mark0n
Copy link

@mark0n mark0n commented Jun 20, 2016

A left behind lock file does not mean the resource is still locked. Bail out if lock cannot be acquired. This fixes #158.

A left behind lock file does not mean the resource is still locked.
Bail out if lock cannot be acquired.
@zeha
Copy link
Contributor

zeha commented Jun 20, 2016

This changes the behaviour though: in those 10 minutes, no other builds will run, even if for most builds waiting for the update does not actually matter.

@mark0n
Copy link
Author

mark0n commented Jun 20, 2016

We are building lots of applications that pull in libraries that have been build by JDG. If we wouldn't run apt-get update on the cowbuilder environment we would potentially build against old versions of our libraries which I consider wrong. This actually has practical relevance since in our case the repo job of the library triggers the source job of the application.

@zeha
Copy link
Contributor

zeha commented Jun 20, 2016

It is my understanding that apt-get update runs anyway, but /in/ the COW instance for this build. The lock is about the general chroot, where updating should only update the minimal Debian image.

@mark0n
Copy link
Author

mark0n commented Jun 20, 2016

On our cluster it seems like apt-get update does not run as part of the cowbuilder_run (I guess I should see that in the build log, right?) - that's why we ran into this issue in the first place. Can you give me a hint how to enable this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-and-provide does not update cowbuilder environment
2 participants