Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pbuilder --override-config #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmiklautz
Copy link
Contributor

Some pbuilder settings, like OTHERMIRRORS for example, aren't applied
if update is called without --override-config. To enable this behaviour
the variable OVERRIDE_COWBUILDER_CONFIG was added. If set to true
cowbuilder is run with --override-config.

To make sure that the proper distribution is used, always run cowbuilder
with --distribution.

Some pbuilder settings, like OTHERMIRRORS for example, aren't applied
if update is called without --override-config. To enable this behaviour
the variable OVERRIDE_COWBUILDER_CONFIG was added. If set to true
cowbuilder is run with --override-config.

To make sure that the proper distribution is used always run cowbuilder
with --distribution.
@bmiklautz
Copy link
Contributor Author

@mika any change to get this in?

@mika
Copy link
Owner

mika commented Nov 21, 2017

Sorry for not responding to this one earlier, beside lack of time I was hold back because of the newly added --distribution "${COWBUILDER_DIST}" and am still not sure about its consequences and what might break in existing setups.

Furthermore I'm reluctant to adding further options (though I fully understand and appreciate your approach to make this configurable!). I'm actually wondering whether there might be any problems with using --override-config by default?

(I looked into testing this today but got sidetracked because of several failing components in jenkins (404-ing plugin files, newly added dependencies,... once again, sigh)

@bmiklautz
Copy link
Contributor Author

No deal. Don't get stressed with it. Just wanted to check up as it would be really convenient to have this upstream ;).

From my tests I saw that --distribution "${COWBUILDER_DIST}" is required that the correct distribution is used. Without, it happened that when using --override-config I had sources lists from a different distribution.
It might possibly be a good idea to use --override-config per default because when it isn't used it can happen that cow images can't be re-used (like in my case when OTHERMIRRORS were used) but I wasn't sure about any side effects either that's why I added the option.

If you want any adaption/fix of the pull request just let me know.

@mika
Copy link
Owner

mika commented Nov 22, 2017

Ok cool :) I'm wondering whether we could come up with a nice test option to verify that the behavior is as intended, maybe we could figure something out together with OTHERMIRRORS usage or so?
(I really need to get some test infrastructure for j-d-g up and running :-/)

@bmiklautz
Copy link
Contributor Author

For reference pbuilder man page for --override-config

              --distribution  ,  --components  ,  --mirror  , --othermirror options are only valid when
              --override-config option is specified in update target, or when pbuilder create is  being
              called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants