#168 Add Java port Whitebox and Expr tests#170
#168 Add Java port Whitebox and Expr tests#170mike-lischke merged 4 commits intomike-lischke:mainfrom
Conversation
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
|
As we see, tests are failed, so bug hunting is required in Java port. I will work slowly on this during the next days when I will have a free time. |
|
Keep in mind the Java port might not be up to date. If the tests return different values you will have to check that the Java code behaves like the TS code. |
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
Signed-off-by: vityaman <vityaman.dev@yandex.ru>
| System.out.println(); | ||
| System.out.println("simpleExpressionTest"); | ||
|
|
||
| @Order(1) |
There was a problem hiding this comment.
I faced with that bug that test results depends on an order of execution. This is becase followSets caching is ignoredTokens aware. I forgot about it, but is actually already fixed in C++ port: https://github.com/mike-lischke/antlr4-c3/blob/main/ports/cpp/source/antlr4-c3/CodeCompletionCore.cpp#L135
There was a problem hiding this comment.
I think we actually can merge this now and I will
- fix this bug at all exiting ports
- setup GitHub Actions to run tests in a shuffled order to catch such bugs
--
|
Thank you @vityaman |
Whiteboxtests fromTypeScripttoJavausing an LLM.Exprtests fromTypeScripttoJavausing an LLM.CodeCompletionCorefromTypeScripttoJavausing an LLM.ignoredTokendependency atfollowSetcomputation