HTTP-redirect

[weslenng]

Overview

This PR implements a HTTP-redirect

In Node side:

• The redirect codes has been retrieved from https://fetch.spec.whatwg.org/#statuses

• The 20 redirects convention was followed as well https://fetch.spec.whatwg.org/#http-redirect-fetch

• The "manual" behavior was not been implemented yet

In Browser side:

• The redirect value is passed to fetch options 😀

Interface

const getJSON = bent("json");

getJSON.redirect = "follow"; // manual, *follow, error

"manual" has no effect on Node side

Closes #87

[mikeal]

There’s too many white space changes for me to read the diff properly ☹️

[rwilson-release]

There’s too many white space changes for me to read the diff properly ☹️

@mikeal You can disable whitespace diff and the PR is quite readable. This is a new feature I believe.

[weslenng]

I'm not interested in pursuing this PR anymore

[VisiontechGitHub]

@mikeal ...

[mikeal]

If someone wants to clean it up and resubmit it then I’ll review it.

I’m quite busy and don’t have to the time to clean up the whitespace is other people’s patches.

[willpower232]

FWIW this PR just helped me debug where I was going wrong in a node package.

The whitespace change is necessary to maintain the indentation as the mkrequest method must essentially call itself again from within itself to follow the redirect manually. This means that the return of mkrequest needs to be captured before it is returned to provide this.

Unless you'd be happy with this line of code to avoid all the indentation changes

const mkrequest = (statusCodes, method, encoding, headers, baseurl) => { const rep = (_url, body = null, _headers = {}, redirLength = 0) => {

I'd gladly resubmit this PR either way but clarification would be handy first 😅

[Orel-A]

I'm not interested in pursuing this PR anymore

Can you recommend a different library that supports redirects?