-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: add esm and cjs paths to browser map for overriden files (#12)
* fix: add esm and cjs paths to browser map for overriden files See evanw/esbuild#1443 for discussion. In brief if you have a project that is built by ipjs and you have file A that imports file B, esbuild (maybe others?) resolves file B using it's full path within the module (e.g. including `esm` or `cjs`), which it then uses as a key to look up overrides in the `browser` map in your `package.json`. If there is an override it'll fail to be found because ipjs doesn't add paths prefixed with `esm` or `cjs` to the browser map where overrides have been delcared in the `exports` map, so the change here is to add files with their full path prefix to the `browser` map. * fix: browser overrides in webpack
- Loading branch information
1 parent
729ffbf
commit 29456b9
Showing
7 changed files
with
35 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
{ "type" : "module" } | ||
{ | ||
"type": "module", | ||
"browser": { | ||
"./src/index.js": "./src/browser.js" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
{ "type" : "module" } | ||
{ | ||
"type": "module", | ||
"browser": { | ||
"./src/index.js": "./src/browser.js" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,6 @@ | ||
{ "type" : "module" } | ||
{ | ||
"type": "module", | ||
"browser": { | ||
"./src/index.js": "./src/browser.js" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters