Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave package access scope to the package configuration #14

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Jan 17, 2020

We just got badly burnt by the current behaviour of this plugin.

Scoped packages, e.g. @org/package are restricted by default, e.g. an npm publish publishes them privately whilst the default behaviour of npm for a unscoped package is to publish it publicly; e.g. package will be release public with a simple npm publish.
This plugin diverts from the default npm behaviour in that it releases all packages, independent of their configuration or the sane npm default, publicly.

references #8

cc @joshua-leyshon-canva

We just got badly burnt by the current behaviour of this plugin.

Scoped packages, e.g. `@org/package` are restricted by default, e.g. an `npm publish` publishes them privately whilst the default behaviour of npm for a unscoped package is to publish it publicly; e.g. `package` will be release `public` with a simple `npm publish`.
This plugin diverts from the default npm behaviour in that it releases all packages, independent of their configuration or the sane npm default, publicly.

references mikeal#8 

cc @joshua-leyshon-canva
@mikeal
Copy link
Owner

mikeal commented Jan 17, 2020

Approved, and I think this will be the final word on whether or not we do initial publishing (we won’t). #13

@mikeal mikeal merged commit 94e29de into mikeal:master Jan 17, 2020
@joscha
Copy link
Contributor Author

joscha commented Jan 18, 2020

Thank you! Can we tag the new version so we can depend on the fix, please?

@joscha joscha deleted the patch-1 branch January 18, 2020 00:51
@mikeal
Copy link
Owner

mikeal commented Jan 18, 2020

hahaha, i rely so heavily on merge-release that i don’t even think about doing manual tags or releases of anything, including merge-release!

the actions were failing since they had some old syntax and action references, updated and it should do a full build and tag soon.

@joscha
Copy link
Contributor Author

joscha commented Jan 20, 2020

I don't think it worked:

Current runner version: '2.164.0'
Prepare workflow directory
Prepare all required actions
Download action repository 'actions/checkout@v1'
Download action repository 'actions/setup-node@v1'
Download action repository 'mikeal/[email protected]'
##[warning]Failed to download action 'https://api.github.com/repos/mikeal/merge-release/tarball/v4.0.9'. Error Response status code does not indicate success: 404 (Not Found).
##[warning]Back off 20.056 seconds before retry.
##[warning]Failed to download action 'https://api.github.com/repos/mikeal/merge-release/tarball/v4.0.9'. Error Response status code does not indicate success: 404 (Not Found).
##[warning]Back off 27.69 seconds before retry.
##[error]Response status code does not indicate success: 404 (Not Found).

as the tag is still missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants