Skip to content

Add a close button to thread panels - #89

Merged
mikecann merged 1 commit into
mikecann:mainfrom
waynesutton:pr/thread-panel-close
Nov 20, 2026
Merged

mikecann merged 1 commit into
mikecann:mainfrom
waynesutton:pr/thread-panel-close

Conversation

@waynesutton

@waynesutton waynesutton commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

A thread opened with Open in New Panel had no way to close it from the panel itself. Its custom title line (title, chips, Share, ⋯) takes the place of the dock tab, and the tab is where the × lives. Clicking the title renames the thread, so the only ways out were right-clicking the empty part of the bar or Move to Main Panel in the sidebar.

The dock now adds a × at the end of the bar whenever a custom header replaces the tab and the panel is closable. It sits after the accessory buttons, shows "Close <title>" on hover, and calls the same close the tab's × does. The main panel isn't closable, so it never gets one. The guide's Open in New Panel paragraph now mentions the × and Move to Main Panel.

Validation on macOS:

  • cargo check -p threadbear-gpui passes on current upstream main (f0b5f66). The cherry-pick conflicted with the new header_fills line; both are kept.
  • On Wayne's fork, ./check.sh --quick passed with this change (1446 s).

Not yet checked by hand in the running app.

🤖 Generated with Claude Code


Summary by cubic

Adds a close button to thread panels in the dock. Threads opened via Open in New Panel replace the dock tab with a custom header, which removed the tab's ×; the only ways to close the panel were the right-click menu or Move to Main Panel in the sidebar.

The dock now appends a × at the end of the bar whenever a custom header replaces the tab and the panel is closable. It sits after the accessory buttons, shows "Close <title>" on hover, and triggers the same close action as a tab's ×. The main panel isn't closable, so it never gets one. The guide's Open in New Panel paragraph now mentions the × and Move to Main Panel.

Written for commit 0a96cb8. Summary will update on new commits.

View guided diff

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mikecann
mikecann merged commit 0569aae into mikecann:main Nov 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants