Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tmohentai] add support #4832

Merged
merged 5 commits into from
Nov 21, 2023
Merged

[Tmohentai] add support #4832

merged 5 commits into from
Nov 21, 2023

Conversation

JSouthGB
Copy link
Contributor

For site-request #4808. You can pass the main content URL or any individual page URL. No support for groups or tags as of right now (I can work on adding them if someone will find it useful).

I'm open to any feedback, particularly the metadata retrieval.

@mikf
Copy link
Owner

mikf commented Nov 20, 2023

You should inherit from GalleryExtractor and use its interface, like for example in architizer.py or nhentai.py.

As for metadata retrieval, text.extr() "works", but it would be better to use text.extract_from(page) and use it to extract data in order of appearance in the site's HTML since it stores the current position internally.

@mikf mikf merged commit 714b1a7 into mikf:master Nov 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants