[TikTok] Add support #6708
Open
[TikTok] Add support #6708
+440
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasualYT31
commented
Dec 22, 2024
CasualYT31
commented
Dec 22, 2024
CasualYT31
commented
Dec 22, 2024
mikf
reviewed
Dec 23, 2024
mikf
reviewed
Dec 23, 2024
This comment has been minimized.
This comment has been minimized.
CasualYT31
commented
Dec 24, 2024
| }, | ||
| { | ||
| "#url" : "https://www.tiktok.com/@chillezy", | ||
| "#comment" : "User profile", |
There was a problem hiding this comment.
I should admit that user profile extraction can be a tiny bit flakey. Very occasionally yt-dlp will fail to extract user profile information and there's not a lot gallery-dl can do about it. Is it okay to keep these tests in, or should they be skipped?
|
Hi @mikf, do you have any outstanding feedback for this PR? Otherwise it's ready for merging now. I've been testing this for a few weeks now and I haven't run into any issues. |
|
Would be nice to have this feature! |
|
bump |
Respond to comments Improve archiving and file naming
In my limited experience, this doesn't mean that gallery-dl can't download the photo post (but this could mean that you can't download the audio)
vt.tiktok.com www.tiktok.com/t/
CasualYT31
force-pushed
the
tiktok-support
branch
from
9d49ed7 to
d835e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for TikTok slideshows.
List of supported URL formats:
/photo//video/vm.tiktok.comvt.tiktok.com/t/www.tiktokv.com/share/videotiktok.com/@username)I haven't performed extensive testing yet so there could well be edge cases that aren't covered by the extractor as it stands right now. I have tested with cookies, however, and I am able to extract photos from private accounts (as well as detect when cookies are required to extract photo URLs).
Closes: #3061
Closes: #4177
Closes: #5646
Closes: #6878