Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discord] add support #6836

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

[discord] add support #6836

wants to merge 18 commits into from

Conversation

zWolfrost
Copy link
Contributor

Closes #454.
I haven't tested it completely so there could still be edge cases that could cause problems.
The extractor requires the user to retrieve their Discord Token following the provided instructions.

@zWolfrost
Copy link
Contributor Author

I had the intention of making this extractor useful especially when writing messages metadata to files using postprocessors, to possibly rebuild whole channels starting from those files, but I recognize that many format keywords (like avatars, banners, messages content etc.) are kind of unnecessary when someone's intention is to just download the images. Should I just hide them by default by prefixing them with an underscore? Other than that, the extractor is now feature-wise completed. Sorry for the mess in commit history.

@mikf
Copy link
Owner

mikf commented Jan 30, 2025

You should extract as much metadata as possible (or reasonable) as long as it does not require additional HTTP requests or a lot of computation that goes to waste most of the time (e.g. twitter.text-tweets), in which case they should be hidden behind a metadata option or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Discord
2 participants