[codex] UX: move profiles into companion header popup#1759
Draft
jqmwa wants to merge 1 commit intomilady-ai:developfrom
Draft
[codex] UX: move profiles into companion header popup#1759jqmwa wants to merge 1 commit intomilady-ai:developfrom
jqmwa wants to merge 1 commit intomilady-ai:developfrom
Conversation
Move the old profile/customization surface into a centered companion-shell Profiles dialog. Validation: - bun run verify (fails due pre-existing repo-wide packages/agent typecheck errors) - bun run build ✅ - bun run verify:lint ✅ - bun run test (fails in unrelated existing suites) - bun run test:e2e (fails in unrelated existing suites and hangs in teardown)
Contributor
Agent Review — Service UnavailableBoth AI reviewers failed to complete the review for this run:
This is likely a temporary API outage. The PR will need to be re-reviewed once services recover.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This UX update moves the profile/character selection flow out of the old dedicated character surface and into the companion header as a centered
Profilespopup besideVoiceandNew Chat.What changed
Profilespopup in the companion/header controlsUX impact
Validation
bun run verify❌ fails due to existing repo-widepackages/agenttype errors unrelated to this changebunx tsc -p packages/app-core/tsconfig.json --noEmit❌ still resolves into those same existingpackages/agenterrorsbun run verify:lint✅bun run build✅bun run test❌ fails in existing unrelated suites:packages/app-core/test/utils/parse-xml-unicode.test.tspackages/app-core/test/app/i18n.test.tspackages/app-core/test/app/inventory-bsc-view.test.tstest/app/public-assets.test.tsbun run test:e2e❌ fails in existing unrelated suites and then hangs in teardown:packages/agent/test/agent-orchestration.e2e.test.tspackages/app-core/test/app/onboarding-full-journey.e2e.test.tspackages/app-core/test/app/pages-navigation-smoke.e2e.test.tspackages/app-core/test/app/shell-mode-switching.e2e.test.tspackages/agent/test/browser-workspace-agent-chat.e2e.test.tsNotes
This PR was isolated onto a clean branch from
upstream/developso it does not include the unrelated history currently present ondex/v3.