Skip to content

[codex] UX: move profiles into companion header popup#1759

Draft
jqmwa wants to merge 1 commit intomilady-ai:developfrom
jqmwa:codex/ux-profiles-header-popup
Draft

[codex] UX: move profiles into companion header popup#1759
jqmwa wants to merge 1 commit intomilady-ai:developfrom
jqmwa:codex/ux-profiles-header-popup

Conversation

@jqmwa
Copy link
Copy Markdown
Contributor

@jqmwa jqmwa commented Apr 8, 2026

Summary

This UX update moves the profile/character selection flow out of the old dedicated character surface and into the companion header as a centered Profiles popup beside Voice and New Chat.

What changed

  • removed the old character-mode shell entry from the active UI flow
  • added a new Profiles popup in the companion/header controls
  • rendered 8 bundled profiles in a wider modal with larger cards
  • added short profile bios and color-coded plugin badges
  • featured richer plugin stacks in the top 4 profiles
  • raised the modal above persistent shell/scratch overlays so it stays visible

UX impact

  • profile selection is now available from the primary chat surface instead of a separate page
  • the popup is easier to scan, with more readable copy and badges that do not crush the card layout
  • the interaction is more discoverable for users already working in the companion shell

Validation

  • bun run verify ❌ fails due to existing repo-wide packages/agent type errors unrelated to this change
  • bunx tsc -p packages/app-core/tsconfig.json --noEmit ❌ still resolves into those same existing packages/agent errors
  • bun run verify:lint
  • bun run build
  • bun run test ❌ fails in existing unrelated suites:
    • packages/app-core/test/utils/parse-xml-unicode.test.ts
    • packages/app-core/test/app/i18n.test.ts
    • packages/app-core/test/app/inventory-bsc-view.test.ts
    • test/app/public-assets.test.ts
  • bun run test:e2e ❌ fails in existing unrelated suites and then hangs in teardown:
    • packages/agent/test/agent-orchestration.e2e.test.ts
    • packages/app-core/test/app/onboarding-full-journey.e2e.test.ts
    • packages/app-core/test/app/pages-navigation-smoke.e2e.test.ts
    • packages/app-core/test/app/shell-mode-switching.e2e.test.ts
    • packages/agent/test/browser-workspace-agent-chat.e2e.test.ts

Notes

This PR was isolated onto a clean branch from upstream/develop so it does not include the unrelated history currently present on dex/v3.

Move the old profile/customization surface into a centered companion-shell Profiles dialog.

Validation:
- bun run verify  (fails due pre-existing repo-wide packages/agent typecheck errors)
- bun run build  ✅
- bun run verify:lint  ✅
- bun run test  (fails in unrelated existing suites)

- bun run test:e2e  (fails in unrelated existing suites and hangs in teardown)
@github-actions github-actions bot added the tests label Apr 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 8, 2026

Agent Review — Service Unavailable

Both AI reviewers failed to complete the review for this run:

  • Claude: failure
  • Codex (fallback): failure

This is likely a temporary API outage. The PR will need to be re-reviewed once services recover.

View workflow run

  1. Decision: REQUEST CHANGES (automated review unavailable — please re-trigger or wait for service recovery)

@github-actions github-actions bot added category:feature Auto-managed semantic PR category trust:contributing Active contributor, building track record (auto-managed) labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:feature Auto-managed semantic PR category tests trust:contributing Active contributor, building track record (auto-managed)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant