fix: add missing error handlers and abort cleanup in async effects#1766
Merged
lalalune merged 1 commit intomilady-ai:developfrom Apr 10, 2026
Merged
Conversation
…ingAgentSettings - ChatView addImageFiles: FileReader promises lacked onerror/onabort handlers, causing promises that never settle on read failure. Also added .catch() on Promise.all to prevent unhandled rejections. - ChatView preflight fetch: added AbortController so the request is cancelled on unmount, preventing state updates on unmounted components. - CodingAgentSettingsSection: added AbortController for the preflight fetch and abort guards before state updates, preventing post-unmount state writes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Agent Review — Service UnavailableBoth AI reviewers failed to complete the review for this run:
This is likely a temporary API outage. The PR will need to be re-reviewed once services recover.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addImageFiles:FileReaderpromises lackedonerror/onaborthandlers, causing promises that never settle on read failure (e.g. permission errors, corrupt files). Added.catch()onPromise.allto prevent unhandled rejections.AbortControllerso the coding-agents preflight request is cancelled on unmount, preventing state updates on unmounted components.AbortControllerfor the preflight fetch and abort guards before state updates, preventing post-unmount state writes when navigating away during the 5-fetch initialization.Test plan
🤖 Generated with Claude Code