POSIX: fix build error of undeclared strcasecmp() #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to do an experiment and I compiled Milkytracker for CYGWIN, just to see how the code was building on POSIX.
Unfortunately, the build process hangs with several errors like this one:
MilkyTracker/src/compression/../ppui/osinterface/posix/PPSystemString_POSIX.h: In member function ‘pp_int32 PPSystemString::compareToNoCase(const PPSystemString&) const’:
MilkyTracker/src/compression/../ppui/osinterface/posix/PPSystemString_POSIX.h:147:24: error: ‘strcasecmp’ was not declared in this scope; did you mean ‘strncmp’?
147 | return strcasecmp(strBuffer, str.strBuffer);
| ^~~~~~~~~~
| strncmp
After a quick check, I discovered that the error is correct.
If you open BasicTypes.h and you look here:
https://github.com/milkytracker/MilkyTracker/blob/60ce53e85fc23c37a15c09911125e134eaa27697/src/ppui/BasicTypes.h#L46
you will see that there are two calls to string.h.
Actually, strcasecmp() is not declared inside string.h but into strings.h (note the final 's' at the end of the file name).
Probably, the intention was to add strings.h but it has been forgotten during the copy-paste process.
Attached patch fixes the tiny error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to do an experiment and I compiled Milkytracker for CYGWIN, just to see how the code was building on POSIX. Unfortunately, the build process hangs with several errors like this one:
After a quick check, I discovered that the error is correct.
If you open
BasicTypes.hand you look here:MilkyTracker/src/ppui/BasicTypes.h
Line 46 in 60ce53e
you will see that there are two calls to
string.h.Actually,
strcasecmp()is not declared insidestring.hbut intostrings.h(note the final 's' at the end of the file name):https://www.man7.org/linux/man-pages/man3/strcasecmp.3.html
Probably, the intention was to add
strings.hbut it has been forgotten during the copy-paste process.So, one call must include
string.hand the other call must includestrings.h.Attached patch fixes the tiny error.