Use the GetLoadingProgress api instead of the InMemoryPercentages in …

…the ShowPartition api response Fix load collection hang issue Signed-off-by: Wen Sun <[email protected]>
milvus-io · Mar 17, 2023 · d6040af · d6040af
1 parent 7fb93bf
commit d6040af
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 39 deletions.
diff --git a/client/client_grpc_collection.go b/client/client_grpc_collection.go
@@ -373,15 +373,15 @@ func (c *GrpcClient) LoadCollection(ctx context.Context, collName string, async
 			default:
 			}
 
-			coll, err := c.ShowCollection(ctx, collName)
+			progress, err := c.GetLoadingProgress(ctx, collName, nil)
 			if err != nil {
 				return err
 			}
-			if coll.Loaded {
-				break
+			if progress == 100 {
+				return nil
 			}
 
-			time.Sleep(200 * time.Millisecond) // TODO change to configuration
+			time.Sleep(500 * time.Millisecond)
 		}
 	}
 	return nil

diff --git a/client/client_grpc_partition.go b/client/client_grpc_partition.go
@@ -149,23 +149,6 @@ func (c *GrpcClient) LoadPartitions(ctx context.Context, collName string, partit
 			return err
 		}
 	}
-	partitions, err := c.ShowPartitions(ctx, collName)
-	if err != nil {
-		return err
-	}
-	m := make(map[string]int64)
-	for _, partition := range partitions {
-		m[partition.Name] = partition.ID
-	}
-	// load partitions ids
-	ids := make(map[int64]struct{})
-	for _, partitionName := range partitionNames {
-		id, has := m[partitionName]
-		if !has {
-			return fmt.Errorf("Collection %s does not has partitions %s", collName, partitionName)
-		}
-		ids[id] = struct{}{}
-	}
 
 	req := &server.LoadPartitionsRequest{
 		DbName:         "", // reserved
@@ -187,28 +170,16 @@ func (c *GrpcClient) LoadPartitions(ctx context.Context, collName string, partit
 				return errors.New("context deadline exceeded")
 			default:
 			}
-			partitions, err := c.ShowPartitions(ctx, collName)
+			percentage, err := c.GetLoadingProgress(ctx, collName, partitionNames)
 			if err != nil {
 				return err
 			}
-			foundLoading := false
-			loaded := 0
-			for _, partition := range partitions {
-				if _, has := ids[partition.ID]; !has {
-					continue
-				}
-				if !partition.Loaded {
-					//Not loaded
-					foundLoading = true
-					break
-				}
-				loaded++
-			}
-			if foundLoading || loaded < len(partitionNames) {
-				time.Sleep(time.Millisecond * 100)
-				continue
+
+			if percentage == 100 {
+				return nil
 			}
-			break
+
+			time.Sleep(500 * time.Millisecond)
 		}
 	}