[Go & Cpp] Fix set type values error (#65)

Signed-off-by: sunby <[email protected]>
milvus-io · Sep 28, 2023 · 2b69464 · 2b69464
1 parent c9eb20b
commit 2b69464
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 16 deletions.
diff --git a/cpp/src/common/utils.cpp b/cpp/src/common/utils.cpp
@@ -51,10 +51,6 @@ Result<std::unique_ptr<schema_proto::Field>> ToProtobufField(const arrow::Field*
 
 Status SetTypeValues(schema_proto::DataType* proto_type, const arrow::DataType* type) {
   switch (type->id()) {
-    case arrow::Type::INT64: {
-      proto_type->set_logic_type(schema_proto::LogicType::INT64);
-      break;
-    }
     case arrow::Type::FIXED_SIZE_BINARY: {
       auto real_type = dynamic_cast<const arrow::FixedSizeBinaryType*>(type);
       auto fixed_size_binary_type = new schema_proto::FixedSizeBinaryType();
@@ -88,7 +84,7 @@ Status SetTypeValues(schema_proto::DataType* proto_type, const arrow::DataType*
       break;
     }
     default:
-      return Status::InvalidArgument("Invalid type id: " + std::to_string(type->id()));
+      return Status::OK();
   }
   return Status::OK();
 }

diff --git a/go/common/utils/utils.go b/go/common/utils/utils.go
@@ -100,16 +100,6 @@ func ToProtobufField(field *arrow.Field) (*schema_proto.Field, error) {
 
 func SetTypeValues(protoType *schema_proto.DataType, dataType arrow.DataType) error {
 	switch dataType.ID() {
-	case arrow.STRING:
-		stringType := schema_proto.LogicType_STRING
-		protoType = &schema_proto.DataType{LogicType: stringType}
-		break
-
-	case arrow.INT64:
-		int64Type := schema_proto.LogicType_INT64
-		protoType = &schema_proto.DataType{LogicType: int64Type}
-		break
-
 	case arrow.FIXED_SIZE_BINARY:
 		realType, ok := dataType.(*arrow.FixedSizeBinaryType)
 		if !ok {
@@ -159,7 +149,6 @@ func SetTypeValues(protoType *schema_proto.DataType, dataType arrow.DataType) er
 		break
 
 	default:
-		return fmt.Errorf("set type values with typeid %s : %w", dataType.ID().String(), ErrInvalidArgument)
 	}
 
 	return nil