[Go] List objects recursively (#71)

Signed-off-by: sunby <[email protected]>
milvus-io · Oct 8, 2023 · 5593abc · 5593abc
1 parent 62be323
commit 5593abc
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/go/io/fs/minio_fs.go b/go/io/fs/minio_fs.go
@@ -74,7 +74,7 @@ func (fs *MinioFs) List(path string) ([]FileEntry, error) {
 		return nil, err
 	}
 	ret := make([]FileEntry, 0)
-	for objInfo := range fs.client.ListObjects(context.TODO(), fs.bucketName, minio.ListObjectsOptions{Prefix: path, Recursive: false}) {
+	for objInfo := range fs.client.ListObjects(context.TODO(), fs.bucketName, minio.ListObjectsOptions{Prefix: path, Recursive: true}) {
 		if objInfo.Err != nil {
 			log.Warn("list object error", zap.Error(objInfo.Err))
 			return nil, objInfo.Err

diff --git a/go/io/fs/minio_fs_test.go b/go/io/fs/minio_fs_test.go
@@ -75,20 +75,15 @@ func (suite *MinioFsTestSuite) TestMinioFsDeleteFile() {
 }
 
 func (suite *MinioFsTestSuite) TestMinioFsList() {
-	file, err := suite.fs.OpenFile("default/a/b")
-	suite.NoError(err)
-	_, err = file.Write([]byte{1})
-	suite.NoError(err)
-	suite.NoError(file.Close())
-	file, err = suite.fs.OpenFile("default/a/b/c")
+	file, err := suite.fs.OpenFile("default/a/b/c")
 	suite.NoError(err)
 	_, err = file.Write([]byte{1})
 	suite.NoError(err)
 	suite.NoError(file.Close())
 
 	entries, err := suite.fs.List("default/a/")
 	suite.NoError(err)
-	suite.EqualValues([]fs.FileEntry{{Path: "a/b"}}, entries)
+	suite.EqualValues([]fs.FileEntry{{Path: "a/b/c"}}, entries)
 }
 
 func (suite *MinioFsTestSuite) TestMinioFsReadFile() {