Add missing virtual destructors

Signed-off-by: Alexandr Guzhva <[email protected]>
milvus-io · Mar 2, 2024 · 974fb6e · 974fb6e
1 parent 9d1ad9c
commit 974fb6e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/cpp/include/milvus-storage/format/reader.h b/cpp/include/milvus-storage/format/reader.h
@@ -23,5 +23,7 @@ class Reader {
   virtual void Close() = 0;
 
   virtual Result<std::shared_ptr<arrow::Table>> ReadByOffsets(std::vector<int64_t>& offsets) = 0;
+
+  virtual ~Reader() = default;
 };
 }  // namespace milvus_storage
diff --git a/cpp/include/milvus-storage/format/writer.h b/cpp/include/milvus-storage/format/writer.h
@@ -26,5 +26,7 @@ class FileWriter {
   virtual int64_t count() = 0;
 
   virtual Status Close() = 0;
+
+  virtual ~FileWriter() = default;
 };
 }  // namespace milvus_storage