[Go] close file after write (#67)

Signed-off-by: sunby <[email protected]>

go/io/fs/factory.go

@@ -14,7 +14,7 @@ func (f *Factory) Create(fsType options.FsType, uri *url.URL) (Fs, error) {
 	case options.InMemory:
 		return NewMemoryFs(), nil
 	case options.LocalFS:
-		return NewLocalFs(), nil
+		return NewLocalFs(uri), nil
 	case options.S3:
 		return NewMinioFs(uri)
 	default:

go/io/fs/local_fs.go

@@ -1,14 +1,17 @@
 package fs
 
 import (
+	"net/url"
 	"os"
 	"path/filepath"
 
 	"github.com/milvus-io/milvus-storage/go/common/log"
 	"github.com/milvus-io/milvus-storage/go/io/fs/file"
 )
 
-type LocalFS struct{}
+type LocalFS struct {
+	path string
+}
 
 func (l *LocalFS) OpenFile(path string) (file.File, error) {
 	// Extract the directory from the path
@@ -66,9 +69,9 @@ func (l *LocalFS) Exist(path string) (bool, error) {
 }
 
 func (l *LocalFS) Path() string {
-	return ""
+	return l.path
 }
 
-func NewLocalFs() *LocalFS {
-	return &LocalFS{}
+func NewLocalFs(uri *url.URL) *LocalFS {
+	return &LocalFS{uri.Path}
 }

go/storage/manifest/manifest.go

@@ -145,7 +145,9 @@ func WriteManifestFile(manifest *Manifest, output file.File) error {
 	if write != len(bytes) {
 		return fmt.Errorf("failed to write whole file, expect: %v, actual: %v", len(bytes), write)
 	}
-
+	if err = output.Close(); err != nil {
+		return err
+	}
 	return nil
 }
 

go/storage/manifest/reader_writer.go

@@ -89,14 +89,14 @@ func (rw ManifestReaderWriter) Write(m *Manifest) error {
 	log.Debug("path", log.String("tmpManifestFilePath", tmpManifestFilePath), log.String("manifestFilePath", manifestFilePath))
 	output, err := rw.fs.OpenFile(tmpManifestFilePath)
 	if err != nil {
-		return fmt.Errorf("save manfiest: %w", err)
+		return fmt.Errorf("open file error: %w", err)
 	}
 	if err = WriteManifestFile(m, output); err != nil {
 		return err
 	}
 	err = rw.fs.Rename(tmpManifestFilePath, manifestFilePath)
 	if err != nil {
-		return fmt.Errorf("save manfiest: %w", err)
+		return fmt.Errorf("rename file error: %w", err)
 	}
 	log.Debug("save manifest file success", log.String("path", manifestFilePath))
 	return nil