Skip to content

Commit

Permalink
[Go] Add scan delete interface (#56)
Browse files Browse the repository at this point in the history
Signed-off-by: sunby <[email protected]>
  • Loading branch information
sunby committed Sep 12, 2023
1 parent 6f78647 commit c847928
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
4 changes: 4 additions & 0 deletions go/reader/record_reader/multi_files_sequential_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ func (m *MultiFilesSequentialReader) Next() bool {
if m.currReader.Next() {
return true
}
if m.currReader.Err() != nil {
m.err = m.currReader.Err()
return false
}
if m.currReader != nil {
m.currReader.Release()
m.currReader = nil
Expand Down
4 changes: 4 additions & 0 deletions go/reader/record_reader/record_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,7 @@ func filtersOnlyContainPKAndVersion(s *schema.Schema, filters []filter.Filter) b
}
return true
}

func MakeScanDeleteReader(manifest *manifest.Manifest, fs fs.Fs) array.RecordReader {
return NewMultiFilesSequentialReader(fs, manifest.GetDeleteFragments(), manifest.GetSchema().DeleteSchema(), option.NewReadOptions())
}
4 changes: 4 additions & 0 deletions go/storage/space.go
Original file line number Diff line number Diff line change
Expand Up @@ -471,3 +471,7 @@ func (s *Space) GetBlobByteSize(name string) (int64, error) {
func (s *Space) GetCurrentVersion() int64 {
return s.manifest.Version()
}

func (s *Space) ScanDelete() (array.RecordReader, error) {
return record_reader.MakeScanDeleteReader(s.manifest, s.fs), nil
}

0 comments on commit c847928

Please sign in to comment.