Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some useless files #38

Merged
merged 1 commit into from
Aug 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions go/storage/manifest/manifest.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,23 +172,3 @@ func (d *DataFile) Path() string {
func NewDataFile(path string) *DataFile {
return &DataFile{path: path}
}

type ManifestV1 struct {
dataFiles []*DataFile
}

func (m *ManifestV1) AddDataFiles(files ...*DataFile) {
m.dataFiles = append(m.dataFiles, files...)
}

func (m *ManifestV1) DataFiles() []*DataFile {
return m.dataFiles
}

func NewManifestV1() *ManifestV1 {
return &ManifestV1{}
}

func WriteManifestFileV1(fs fs.Fs, manifest *ManifestV1) error {
return nil
}
98 changes: 0 additions & 98 deletions go/storage/record_reader.go

This file was deleted.

98 changes: 0 additions & 98 deletions go/storage/reference_space.go

This file was deleted.

37 changes: 2 additions & 35 deletions go/storage/space_test.go
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
package storage_test

import (
"testing"

"github.com/milvus-io/milvus-storage-format/common/log"
"github.com/milvus-io/milvus-storage-format/storage/options/option"
"github.com/milvus-io/milvus-storage-format/storage/options/schema_option"
"github.com/milvus-io/milvus-storage-format/storage/schema"
"testing"

"github.com/apache/arrow/go/v12/arrow"
"github.com/apache/arrow/go/v12/arrow/array"
Expand Down Expand Up @@ -112,40 +113,6 @@ func (suite *SpaceTestSuite) TestSpaceReadWrite() {
suite.ElementsMatch([]int64{1}, resVals)
}

func (suite *DefaultSpaceTestSuite) TestSpaceReadWrite() {
field := arrow.Field{
Name: "int32",
Type: arrow.PrimitiveTypes.Int32,
Nullable: false,
}

schem := arrow.NewSchema([]arrow.Field{field}, nil)
builder := array.NewInt32Builder(memory.DefaultAllocator)
builder.AppendValues([]int32{1, 3, 4, 5, 6, 8, 2, 4, 6}, nil)
arr := builder.NewArray()
rec := array.NewRecord(schem, []arrow.Array{arr}, int64(arr.Len()))
recReader, err := array.NewRecordReader(schem, []arrow.Record{rec})
suite.NoError(err)

space := storage.NewReferenceSpace(schem, &option.SpaceOptions{Fs: option.InMemory})
writeOpt := &option.WriteOptions{MaxRecordPerFile: 10}
space.Write(recReader, writeOpt)

f := filter.NewConstantFilter(filter.GreaterThan, "int32", int32(3))
res, err := space.Read(&option.ReadOptions{Filters: map[string]filter.Filter{"int32": f}})
suite.NoError(err)

var resVals []int32
for res.Next() {
rec := res.Record()
cols := rec.Columns()
values := cols[0].(*array.Int32).Int32Values()
resVals = append(resVals, values...)
}

suite.ElementsMatch([]int32{4, 5, 6, 8, 4, 6}, resVals)
}

func TestDefaultSpaceTestSuite(t *testing.T) {
suite.Run(t, new(DefaultSpaceTestSuite))
suite.Run(t, new(SpaceTestSuite))
Expand Down
Loading