Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cpp] Create blob directory in Open #86

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[Cpp] Create blob directory in Open #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/milvus-storage/common/utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ std::string GetManifestDir(const std::string& path);
std::string GetScalarDataDir(const std::string& path);
std::string GetVectorDataDir(const std::string& path);
std::string GetDeleteDataDir(const std::string& path);
std::string GetBolbDir(const std::string& path);
std::string GetBlobDir(const std::string& path);

std::string GetNewBlobFilePath(const std::string& path);
} // namespace milvus_storage
2 changes: 1 addition & 1 deletion cpp/src/common/utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ std::string GetManifestTmpFilePath(const std::string& path, const int64_t versio
return arrow::fs::internal::JoinAbstractPath(
std::vector<std::string_view>{path, kManifestsDir, std::to_string(version) + kManifestTempFileSuffix});
}
std::string GetBolbDir(const std::string& path) {
std::string GetBlobDir(const std::string& path) {
return arrow::fs::internal::JoinAbstractPath(std::vector<std::string_view>{path, kBlobDir});
}

Expand Down
1 change: 1 addition & 0 deletions cpp/src/storage/space.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ Result<std::unique_ptr<Space>> Space::Open(const std::string& uri, Options optio
RETURN_ARROW_NOT_OK(fs->CreateDir(GetScalarDataDir(path)));
RETURN_ARROW_NOT_OK(fs->CreateDir(GetVectorDataDir(path)));
RETURN_ARROW_NOT_OK(fs->CreateDir(GetDeleteDataDir(path)));
RETURN_ARROW_NOT_OK(fs->CreateDir(GetBlobDir(path)));

ASSIGN_OR_RETURN_NOT_OK(auto info_vec, FindAllManifest(fs, path));
if (info_vec.empty()) {
Expand Down