Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cpp]: Fix WriteBlob typo #97

Merged
merged 1 commit into from
Dec 13, 2023
Merged

[Cpp]: Fix WriteBlob typo #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/include/milvus-storage/storage/space.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class Space {
static Result<std::unique_ptr<Space>> Open(const std::string& uri, Options options);

// Write a blob to space. Will return a error if replace is false and a blob with the same name exists.
Status WriteBolb(std::string name, void* blob, int64_t length, bool replace = false);
Status WriteBlob(std::string name, void* blob, int64_t length, bool replace = false);

// Read a blob from space, the target must have enough size to hold this blob.
Status ReadBlob(std::string name, void* target);
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/storage/space.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ std::unique_ptr<arrow::RecordBatchReader> Space::Read(std::shared_ptr<ReadOption
return RecordReader::MakeRecordReader(manifest_, manifest_->schema(), fs_, delete_fragments_, option);
}

Status Space::WriteBolb(std::string name, void* blob, int64_t length, bool replace) {
Status Space::WriteBlob(std::string name, void* blob, int64_t length, bool replace) {
if (!replace && manifest_->has_blob(name)) {
return Status::InvalidArgument("blob already exist");
}
Expand Down