Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: decrease cpu overhead during filter segments on datacoord #34231

Open
wants to merge 2 commits into
base: 2.4
Choose a base branch
from

Conversation

jaime0815
Copy link
Contributor

issue: #33129
pr: #33130
pr: #33373

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Jun 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.48%. Comparing base (1c6e850) to head (f1bb0cf).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34231       +/-   ##
===========================================
- Coverage   85.61%   72.48%   -13.13%     
===========================================
  Files         761     1015      +254     
  Lines      107715   130464    +22749     
===========================================
+ Hits        92222    94573     +2351     
- Misses      11490    31892    +20402     
+ Partials     4003     3999        -4     
Files Coverage Δ
internal/datacoord/segment_info.go 89.21% <100.00%> (+1.91%) ⬆️
internal/querynodev2/segments/pool.go 100.00% <100.00%> (ø)
internal/querynodev2/segments/segment.go 66.43% <0.00%> (ø)
internal/datacoord/segment_operator.go 85.18% <66.66%> (-6.82%) ⬇️

... and 279 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants