Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: descriptor event in previous version not has nullable to parse error #34235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 27, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 27, 2024
Copy link
Contributor

mergify bot commented Jun 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jun 27, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jun 28, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

fix
Signed-off-by: lixinguo <[email protected]>
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.86%. Comparing base (96dcee5) to head (1b6a154).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34235      +/-   ##
==========================================
+ Coverage   80.84%   80.86%   +0.01%     
==========================================
  Files        1085     1080       -5     
  Lines      137510   137865     +355     
==========================================
+ Hits       111171   111481     +310     
- Misses      22114    22156      +42     
- Partials     4225     4228       +3     
Files Coverage Δ
internal/core/src/storage/DataCodec.cpp 71.66% <100.00%> (-2.53%) ⬇️
internal/core/src/storage/Event.h 80.00% <ø> (+7.27%) ⬆️
internal/core/src/storage/InsertData.cpp 84.00% <ø> (-0.32%) ⬇️
internal/storage/binlog_writer.go 85.00% <100.00%> (ø)
internal/core/src/storage/Event.cpp 80.47% <80.00%> (-1.21%) ⬇️
internal/storage/binlog_reader.go 89.47% <50.00%> (-3.26%) ⬇️
internal/storage/event_data.go 92.46% <84.61%> (-0.49%) ⬇️

... and 228 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants