Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip text index creation when segment is zero after sorting #39962

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

issue: #39961

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 18, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 18, 2025
@xiaocai2333 xiaocai2333 force-pushed the fix_zero_rows_after_sort branch from 3223768 to d2eeca1 Compare February 18, 2025 08:41
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (7695924) to head (d2eeca1).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39962       +/-   ##
===========================================
+ Coverage   69.62%   79.79%   +10.16%     
===========================================
  Files         307     1500     +1193     
  Lines       27467   207392   +179925     
===========================================
+ Hits        19124   165483   +146359     
- Misses       8343    35884    +27541     
- Partials        0     6025     +6025     
Components Coverage Δ
Client 79.25% <ø> (∅)
Core 69.63% <ø> (+0.01%) ⬆️
Go 81.45% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/indexnode/task_stats.go 73.23% <100.00%> (ø)

... and 1194 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 18, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 18, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Feb 19, 2025
sre-ci-robot pushed a commit that referenced this pull request Feb 19, 2025
@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 20, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/indexnode dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants