Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use v2 package name for pkg module #39990

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

Related to #39095

https://go.dev/doc/modules/version-numbers

Update pkg version according to golang dep version convention

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/dependency Pull requests that update a dependency file area/internal-api area/test sig/testing test/integration integration test labels Feb 19, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 19, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Feb 19, 2025
@congqixia congqixia force-pushed the enhance/fix_pkg_version branch from a940f97 to c687de4 Compare February 19, 2025 03:27
Copy link
Contributor

mergify bot commented Feb 19, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia congqixia force-pushed the enhance/fix_pkg_version branch from c687de4 to 52f01a9 Compare February 19, 2025 04:10
Copy link
Contributor

mergify bot commented Feb 19, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 19, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.61%. Comparing base (f0d3d98) to head (e655d31).
Report is 3 commits behind head on master.

❌ Your project check has failed because the head coverage (69.61%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (f0d3d98) and HEAD (e655d31). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f0d3d98) HEAD (e655d31)
3 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39990       +/-   ##
===========================================
- Coverage   80.56%   69.61%   -10.95%     
===========================================
  Files        1465      307     -1158     
  Lines      205366    27491   -177875     
===========================================
- Hits       165455    19139   -146316     
+ Misses      33893     8352    -25541     
+ Partials     6018        0     -6018     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.61% <ø> (ø)
Go ∅ <ø> (∅)

see 1158 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 19, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@congqixia congqixia force-pushed the enhance/fix_pkg_version branch from 1b57f0a to 14c2286 Compare February 19, 2025 08:16
@mergify mergify bot added the ci-passed label Feb 19, 2025
Related to milvus-io#39095

https://go.dev/doc/modules/version-numbers

Update pkg version according to golang dep version convention

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/fix_pkg_version branch from 14c2286 to e655d31 Compare February 21, 2025 02:30
@mergify mergify bot removed the ci-passed label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/internal-api area/test dco-passed DCO check passed. go Pull requests that update Go code kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants