-
Notifications
You must be signed in to change notification settings - Fork 3.7k
docs: fix version inconsistencies and add conan troubleshooting in DEVELOPMENT.md #45926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…client Add support for HNSW_SQ, HNSW_PQ, and HNSW_PRQ index types in the Go client to match the Python SDK functionality. - Add HNSWSQ, HNSWPQ, and HNSWPRQ index type constants - Implement NewHNSWSQIndex with sq_type and optional refine support - Implement NewHNSWPQIndex with pqM, nbits and optional refine support - Implement NewHNSWPRQIndex with pqM, nbits and optional refine support - Add NewHNSWQuantAnnParam for search with refine_k parameter Fixes milvus-io#44635 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
…VELOPMENT.md - Update Go version requirement from 1.21 to 1.22 (consistent with code) - Update CMake version requirement from 3.18 to 3.25 - Update Conan version from 1.61 to 1.64.1 (consistent with install command) - Add instructions for clearing Conan cache when encountering build issues - Add FAQ entry for libiberty and other missing dependency errors Fixes milvus-io#45521 Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: murataslan1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@murataslan1 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure: Where Example: Please review and update your PR to comply with these guidelines. |
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45926 +/- ##
=======================================
Coverage 82.73% 82.73%
=======================================
Files 524 524
Lines 82326 82326
=======================================
Hits 68111 68111
Misses 14215 14215
🚀 New features to boost your workflow:
|
Summary
This PR fixes version inconsistencies in DEVELOPMENT.md and adds troubleshooting guidance for common Conan build issues.
Changes
Version Updates
>= 1.21to>= 1.22(consistent with the note in the Go section)>= 3.18to>= 3.25(consistent with the note in the CMake section)1.61to1.64.1(consistent with the install command)New Troubleshooting
libibertyand other missing dependency errorsRelated Issue
Fixes #45521
Background
Users were encountering build failures with errors like:
This happens when users have an outdated Conan cache. The libiberty dependency has been removed from Milvus, but old cache entries can cause issues.