Skip to content

Conversation

@oxyzenQ
Copy link

@oxyzenQ oxyzenQ commented Nov 30, 2025

  • correct spelling and terminology in configuration comments and docstrings (codecov.yml, configs/milvus.yaml, internal/querycoordv2/server.go, internal/datacoord/import_util.go)
  • clean up developer documentation typos and grammar in design docs and guides (geometry, knowhere, data_coord, local proto workflow)
  • improve clarity of filter/output_field descriptions in geometry design doc

Author: rezky_nightky [email protected]
Timestamp: 2025-11-30T13:56:03Z
Repository: milvus
Branch: master
Signing: GPG (989AF9F0)
Performance: 13 files, +144/-150 lines

- correct spelling and terminology in configuration comments and docstrings (codecov.yml, configs/milvus.yaml, internal/querycoordv2/server.go, internal/datacoord/import_util.go)
- clean up developer documentation typos and grammar in design docs and guides (geometry, knowhere, data_coord, local proto workflow)
- improve clarity of filter/output_field descriptions in geometry design doc

Author: rezky_nightky <[email protected]>
Timestamp: 2025-11-30T13:56:03Z
Repository: milvus
Branch: master
Signing: GPG (989AF9F0)
Performance: 13 files, +144/-150 lines
@sre-ci-robot
Copy link
Contributor

Welcome @oxyzenQ! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the test/integration integration test label Nov 30, 2025
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 30, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: oxyzenQ
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2025

@oxyzenQ Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Nov 30, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2025

@oxyzenQ

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  • build(deps): for dependency updates from Dependabot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Nov 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.72%. Comparing base (b886b14) to head (b26319d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #45962       +/-   ##
===========================================
+ Coverage   76.07%   82.72%    +6.65%     
===========================================
  Files        1887      524     -1363     
  Lines      294833    82346   -212487     
===========================================
- Hits       224280    68118   -156162     
+ Misses      63153    14228    -48925     
+ Partials     7400        0     -7400     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 82.72% <ø> (ø)
Go ∅ <ø> (∅)
see 1363 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify
Copy link
Contributor

mergify bot commented Nov 30, 2025

@oxyzenQ cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test do-not-merge/invalid-pr-format needs-dco DCO is missing in this pull request. sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants