-
Notifications
You must be signed in to change notification settings - Fork 3.7k
docs: fix typos and clarify terminology across guides and configs #45962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- correct spelling and terminology in configuration comments and docstrings (codecov.yml, configs/milvus.yaml, internal/querycoordv2/server.go, internal/datacoord/import_util.go) - clean up developer documentation typos and grammar in design docs and guides (geometry, knowhere, data_coord, local proto workflow) - improve clarity of filter/output_field descriptions in geometry design doc Author: rezky_nightky <[email protected]> Timestamp: 2025-11-30T13:56:03Z Repository: milvus Branch: master Signing: GPG (989AF9F0) Performance: 13 files, +144/-150 lines
|
Welcome @oxyzenQ! It looks like this is your first PR to milvus-io/milvus 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oxyzenQ The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@oxyzenQ Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
|
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure: Where Example: Please review and update your PR to comply with these guidelines. |
|
[ci-v2-notice]
To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #45962 +/- ##
===========================================
+ Coverage 76.07% 82.72% +6.65%
===========================================
Files 1887 524 -1363
Lines 294833 82346 -212487
===========================================
- Hits 224280 68118 -156162
+ Misses 63153 14228 -48925
+ Partials 7400 0 -7400
🚀 New features to boost your workflow:
|
|
@oxyzenQ cpu-e2e job failed, comment |
Author: rezky_nightky [email protected]
Timestamp: 2025-11-30T13:56:03Z
Repository: milvus
Branch: master
Signing: GPG (989AF9F0)
Performance: 13 files, +144/-150 lines