Skip to content

Conversation

@aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 1, 2025

relate: #42589

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 1, 2025
@sre-ci-robot
Copy link
Contributor

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.99%. Comparing base (3fc309b) to head (ef3895d).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task_search.go 40.00% 6 Missing and 3 partials ⚠️
internal/proxy/highlighter.go 50.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (42.85%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (75.99%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #45984      +/-   ##
==========================================
- Coverage   76.04%   75.99%   -0.06%     
==========================================
  Files        1890     1890              
  Lines      295322   295335      +13     
==========================================
- Hits       224575   224434     -141     
- Misses      63319    63457     +138     
- Partials     7428     7444      +16     
Components Coverage Δ
Client 78.17% <ø> (ø)
Core 82.72% <ø> (ø)
Go 74.04% <51.85%> (-0.08%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/highlighter.go 37.82% <50.00%> (+0.18%) ⬆️
internal/proxy/task_search.go 69.46% <40.00%> (+0.09%) ⬆️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aoiasd aoiasd force-pushed the highlight branch 2 times, most recently from c1e9565 to 20063c2 Compare December 1, 2025 12:10
@mergify
Copy link
Contributor

mergify bot commented Dec 1, 2025

@aoiasd cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 2, 2025

/run-cpu-e2e

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 2, 2025

/ci-rerun-e2e-arm

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 2, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2025

@aoiasd cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Contributor

mergify bot commented Dec 2, 2025

@aoiasd cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

@aoiasd cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

@aoiasd cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@junjiejiangjjj
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8efe9cc into milvus-io:master Dec 4, 2025
16 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants