Skip to content

Comments

Provide proxy on node client creation#738

Merged
yeastplume merged 1 commit intomimblewimble:masterfrom
ardocrat:wallet_node_client_proxy
Jun 18, 2025
Merged

Provide proxy on node client creation#738
yeastplume merged 1 commit intomimblewimble:masterfrom
ardocrat:wallet_node_client_proxy

Conversation

@ardocrat
Copy link
Contributor

With current implementation we could not provide proxy configuration to HTTPNodeClient on wallet creation for RPC communication, also there was hardcoded socks5h scheme used for Tor client at another place.

Copy link
Member

@yeastplume yeastplume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yeastplume
Copy link
Member

Merging, test failure on windows but unrelated

@yeastplume yeastplume merged commit 930a44d into mimblewimble:master Jun 18, 2025
7 of 8 checks passed
@ardocrat ardocrat deleted the wallet_node_client_proxy branch June 19, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants