Docker package build#3816
Merged
DavidBurkett merged 9 commits intomimblewimble:masterfrom Jan 6, 2026
Merged
Conversation
This was referenced Dec 30, 2025
Member
|
The duplicate Right now the need for subcommand-level flags is coming from the Dockerfile using: Because Docker only appends args, that forces things like An alternative that avoids changing the CLI at all would be to restructure the Dockerfile like this: That preserves the existing, canonical CLI structure and lets users do: This still works cleanly with docker-compose via |
DavidBurkett
reviewed
Jan 6, 2026
DavidBurkett
reviewed
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added docker image build on push at master branch.
--testnetargument in the end ofgrin server runcommand to use single image at compose files.Release member from Mimblewimble should create Secrets for repo (https://github.com/mimblewimble/grin/settings/secrets/actions):
GHCR_USERNAMEwith name of organisation (mimblewimble)GHCR_TOKENfrom here https://github.com/settings/tokens/new (choose write:packages, read:packages permissions).After build need to check that package is public at https://ghcr.io/mimblewimble/grin and change visibility if needed here https://github.com/orgs/mimblewimble/packages/container/grin/settings.