Skip to content

Fix PIBD sync stuck #3817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DavidBurkett merged 10 commits into from
Jan 8, 2026
+316 −124
Merged

Fix PIBD sync stuck #3817

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6f902c3
pibd: record segment peer to exclude it from re-request
ardocrat Dec 19, 2025
e4b2ef4
desegmenter is blocked on a missing kernel
wiesche89 Nov 22, 2025
3d10cd8
segment iter
wiesche89 Nov 23, 2025
c75a877
add indexing
wiesche89 Nov 23, 2025
3fc7803
pibd: log excluded peer
ardocrat Dec 19, 2025
10fc5e7
segment batch optimization
wiesche89 Nov 23, 2025
e8d1ff2
pibd: debug logging for stale requests
ardocrat Jan 6, 2026
f58a416
pibd: filter excluded peer
ardocrat Jan 6, 2026
4738d70
pibd: check existing kernel segment identifier
ardocrat Jan 7, 2026
46bda45
pibd: simplify peer selection condition
ardocrat Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion chain/src/pibd_params.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,12 @@ pub const KERNEL_SEGMENT_HEIGHT: u8 = 11;
/// Maximum number of received segments to cache (across all trees) before we stop requesting others
pub const MAX_CACHED_SEGMENTS: usize = 15;

/// Number of segments to apply in a single LMDB transaction
pub const SEGMENT_APPLY_BATCH_SIZE: usize = 4;

/// How long the state sync should wait after requesting a segment from a peer before
/// deciding the segment isn't going to arrive. The syncer will then re-request the segment
pub const SEGMENT_REQUEST_TIMEOUT_SECS: i64 = 60;
pub const SEGMENT_REQUEST_TIMEOUT_SECS: i64 = 20;
Copy link
Member

@DavidBurkett DavidBurkett Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be okay, but we do have a lot of slow peers on the network and the rangeproof segments can be kind of large IIUC. It'd be a good idea to look for someone with a slow connection to test this change and make sure we aren't causing needless churn with the timeout reduction.

Copy link
Contributor Author

@ardocrat ardocrat Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will try to simulate slow connection to see the difference.


/// Number of simultaneous requests for segments we should make. Note this is currently
/// divisible by 3 to try and evenly spread requests amount the 3 main MMRs (Bitmap segments
Expand Down
Loading