refactor: replace useTheme hook with useAppTheme in DevSignerScreen a… - #137
Open
ABEEGOLD wants to merge 2 commits into
Open
Conversation
…nd update package-lock.json
|
@ABEEGOLD Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
please resolve conflict, pull lastest updates on main before pushing |
Contributor
|
please resolve your conflict, by pulling before pushing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closed #60
Description
Fixes #60.
This PR aligns the DevSignerScreen with the rest of the app's theme architecture by transitioning it to use the higher-level useAppTheme hook from the ThemeProvider, rather than importing the lower-level useTheme hook directly. This ensures the screen properly taps into the app's centralized theme context.
Changes Made
Updated import in src/screens/DevSignerScreen.tsx to use useAppTheme instead of useTheme.
Ensured npm run typecheck passes successfully.
Manual Verification Steps
Launch the app and navigate to the DevSignerScreen.
Go to the Settings screen and toggle the theme (e.g., from Light to Dark mode).
Navigate back to the DevSignerScreen and confirm that it immediately reflects the active theme without needing a reload, matching the behavior of the rest of the application.