T 1250801: Conduit library Enhance Security by Removing #file Usage
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bconway99
approved these changes
Sep 14, 2023
AnshulMindbody
deleted the
Task/1250801-Conduit-library-Enhance-Security-by-Removing-`#file`-Usage
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes (pick all that apply):
Summary
This pull request addresses potential security concerns related to the disclosure of absolute internal file paths in our application. By switching from #file to #fileID, we reduce the risk of revealing sensitive path information which can be exploited by malicious actors. This change aligns with best practices for preserving application security and integrity.
Implementation
Replace #file to #fileID