New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T 1331575: Updated Refresh Token API minimumExpirationTime to 5 minutes #169

Open

amrutakamat-mindbody wants to merge 1 commit into main from Task/1331575-Update-Refresh-Token-Call-to-5-minutes

amrutakamat-mindbody commented Jun 28, 2024

I've read, understood, and done my best to follow the CONTRIBUTING guidelines.

This pull request includes (pick all that apply):

Summary

The refresh token expiry has been change to 1 hour instead of 24 hours.
Previously, the refresh token API call timings before expiry i.e. minimumExpirationTime was set to 900 i.e. 15 minutes for 24 hours.
So, updated minimumExpirationTime to 5 minutes.

Implementation

It includes a change to the BearerToken struct in the Sources/Conduit/Auth/Models/OAuth2Token.swift file. The minimumExpirationTime for the isValid property has been reduced from 15 minutes to 5 minutes. This change affects how we determine the validity of the token.

Test Plan

Test on all projects and verify refresh token API has been called 5 minutes before expiry.


          T 1331575: Updated Refresh Token API minimumExpirationTime to 5 minutes

8cf0985

AnshulMindbody requested review from bconway99 and AnshulMindbody

June 28, 2024 11:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment