-
Notifications
You must be signed in to change notification settings - Fork 639
Add testing infrastructure #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@MaxRobinsonTheGreat @uukelele-scratch I am not able to add reviewers in the github UI - let me know if you have any questions or need anything from me. Have a great rest of your weekend! |
- Add Jest testing framework with ES module support - Create unit tests for core functionality: - Command parsing and execution system - Task validation and processing logic - Settings configuration handling - Model configuration and API selection - Utility functions - Add integration tests for basic module loading - Set up GitHub Actions CI/CD pipeline for automated testing - Add test coverage reporting with Codecov integration - Include comprehensive test documentation - Optimize CI performance with npm and Jest caching - Test on Node.js 20.x and 22.x (compatible versions) - All tests verify existing functionality without modifications - 72 tests passing with good coverage of core components
|
I think for testing, we should launch them into a real Minecraft world for testing. Maybe configure repository secrets like $TESTING_SERVER_HOST and IP, as well as $TEST_API_KEY |
|
@icwhite wanna test this out? |
uukelele-scratch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test system is fine, but the tests themselves are a bit basic. It would be way better to get it to join an actual Minecraft instance and check if the bot can join, run actions, etc.
|
@uukelele-scratch Haha yeah, that would be epic 😄 I’d suggest we merge this as-is and track the live-server testing in a separate issue/PR. |
|
@icwhite @MaxRobinsonTheGreat let me know if you need anything else from me - would love to get this merged :) |
| Automated testing on: | ||
| - Push to `develop`, `unit-test`, `main` branches | ||
| - Pull requests to `develop` or `main` branches | ||
| - Node.js versions 18.x and 20.x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow tests for versions 20.x and 22.x, not 18.x and 20.x
Hi! Big fan of the project. Found you from the excellent YouTube videos from Emergent Garden and figured why not help a bit. This PR adds testing infrastructure, which should allow you to iterate faster and more confidently. Let me know if you have any questions or feedback.
Example successful test run