Fix: include off-hand items when discarding (fixes #553) #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
#618 attempts to achieve a much simpler solution |
Contributor
|
seems to include #659 inside here as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #553 where items held in the off-hand were not found by
skills.discardand therefore could not be tossed.Changes:
src/agent/library/skills.js:discard()now searchesbot.inventory.slotsas a fallback (this includes off-hand slots) and uses the existingbot.toss()to remove items.tests/test_discard_offhand.js: small unit-style test that stubs a bot with an off-hand-like slot and verifiesdiscardcallstoss.Why:
bot.inventory.items()may not include off-hand/armor slots in some runtimes; scanninginventory.slotsensures items in off-hand are considered.Notes:
Please let me know if you'd like the test excluded from the PR; otherwise CI/maintainers can review and merge.