Skip to content

Commit

Permalink
Include provider ID in minder CLI response (#5029)
Browse files Browse the repository at this point in the history
Fixed the issue where deleting a provider by its ID was not possible due to the missing provider ID in the CLI response
  • Loading branch information
navnitms authored Nov 22, 2024
1 parent c6efd48 commit 8b25d8c
Showing 6 changed files with 1,059 additions and 1,035 deletions.
1 change: 1 addition & 0 deletions cmd/cli/app/provider/provider_get.go
Original file line number Diff line number Diff line change
@@ -81,6 +81,7 @@ func GetProviderCommand(ctx context.Context, cmd *cobra.Command, _ []string, con
impls := getImplementsAsStrings(p)
afs := getAuthFlowsAsStrings(p)

t.AddRow("ID", p.GetId())
t.AddRow("Name", p.GetName())
t.AddRow("Project", p.GetProject())
t.AddRow("Version", p.GetVersion())
1 change: 1 addition & 0 deletions docs/docs/ref/proto.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions internal/controlplane/handlers_providers.go
Original file line number Diff line number Diff line change
@@ -283,6 +283,7 @@ func protobufProviderFromDB(
}

return &minderv1.Provider{
Id: p.ID.String(),
Name: p.Name,
Project: p.ProjectID.String(),
Version: p.Version,
4 changes: 4 additions & 0 deletions pkg/api/openapi/minder/v1/minder.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 8b25d8c

Please sign in to comment.