Skip to content

Skip testdata yaml files#5240

Merged
eleftherias merged 1 commit intomindersec:mainfrom
eleftherias:skip-testdata-yaml-files
Jan 2, 2025
Merged

Skip testdata yaml files#5240
eleftherias merged 1 commit intomindersec:mainfrom
eleftherias:skip-testdata-yaml-files

Conversation

@eleftherias
Copy link
Copy Markdown
Contributor

Summary

Our make test target wasn't aware of the .testdata directories and was treating yaml files within those directories as ruletypes.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

@eleftherias eleftherias requested a review from a team as a code owner January 2, 2025 08:02
@eleftherias eleftherias merged commit 85ec911 into mindersec:main Jan 2, 2025
@eleftherias eleftherias deleted the skip-testdata-yaml-files branch January 2, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants