Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce rego function to parse TOML files #5294

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Jan 13, 2025

Summary

This introduces parse_toml to our rego library. It allows us to parse
TOML files in order to more easily write policies for things like
pyproject.toml.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This introduces `parse_toml` to our rego library. It allows us to parse
TOML files in order to more easily write policies for things like
`pyproject.toml`.

Signed-off-by: Juan Antonio Osorio <[email protected]>
@JAORMX JAORMX requested a review from a team as a code owner January 13, 2025 16:23
@JAORMX JAORMX merged commit cc38ccd into mindersec:main Jan 14, 2025
26 checks passed
@JAORMX JAORMX deleted the rego-toml branch January 14, 2025 08:10
return nil, err
}

// Convert the YAML string into a Go map
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
// Convert the YAML string into a Go map
// Convert the TOML string into a Go map

return rego.Function1(
&rego.Function{
Name: "parse_toml",
// Takes one string argument (the YAML content) and returns any type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
// Takes one string argument (the YAML content) and returns any type
// Takes one string argument (the TOML content) and returns any type

@eleftherias
Copy link
Contributor

Oops didn't realise it was already merged, I was too slow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants